Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netsync: Dont let limitAdd shrink map below limit. #3445

Merged
merged 1 commit into from
Sep 12, 2024
Merged

netsync: Dont let limitAdd shrink map below limit. #3445

merged 1 commit into from
Sep 12, 2024

Conversation

jholdstock
Copy link
Member

Noticed while reviewing #3444

@jholdstock
netsync: Dont let limitAdd shrink map below limit.
96eb6a3 
Without checking for pre-existing elements it was possible for limitAdd
to shrink a map below the limit.
@jholdstock jholdstock mentioned this pull request Sep 11, 2024
Merged
@davecgh davecgh added this to the 2.1.0 milestone Sep 11, 2024
davecgh
davecgh reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait to approve until after #3444, because it relies on that.

@davecgh davecgh merged commit e28f4e4 into decred:master Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jholdstock @davecgh